Skip to content

[Feature] Dynamically load net module to remove dependencies of mmdeploy.so #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 28, 2023
Merged

[Feature] Dynamically load net module to remove dependencies of mmdeploy.so #1776

merged 8 commits into from
Feb 28, 2023

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented Feb 17, 2023

Motivation

Move inference engine library dependencies from mmdeploy.so to net module

@irexyc irexyc requested a review from lzhangzz February 17, 2023 07:17
@lzhangzz
Copy link
Collaborator

got link error on Linux

/usr/bin/ld: ../../lib/libmmdeploy_net_module.a(net_loader.cpp.o): undefined reference to symbol 'dlopen@@GLIBC_2.2.5'
/usr/bin/ld: /lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

net_module need to link dl

@lzhangzz lzhangzz mentioned this pull request Feb 23, 2023
Merged
lzhangzz
lzhangzz reviewed Feb 24, 2023
View reviewed changes
lvhan028
lvhan028 reviewed Feb 27, 2023
View reviewed changes
lvhan028
lvhan028 reviewed Feb 27, 2023
View reviewed changes
lvhan028
lvhan028 reviewed Feb 27, 2023
View reviewed changes
lvhan028
lvhan028 reviewed Feb 27, 2023
View reviewed changes
lvhan028
lvhan028 reviewed Feb 27, 2023
View reviewed changes
@lvhan028 lvhan028 merged commit 29b29ee into open-mmlab:dev-1.x Feb 28, 2023
irexyc added a commit to irexyc/mmdeploy that referenced this pull request Mar 1, 2023
@irexyc
[Feature] Dynamically load net module to remove dependencies of mmdep…
1bf2149 
…loy.so (open-mmlab#1776)

* dynamic load net module

* export xxx_net

* add runpath

* link dl

* remove -ldl for macos

* fix rpath

* module -> shared

* set MMDEPLOY_DYNAMIC_BACKEND OFF when MMDEPLOY_BUILD_SDK_MONOLITHIC is OFF
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
@irexyc @lvhan028
[Feature] Dynamically load net module to remove dependencies of mmdep…
5d01469 
…loy.so (#1776)

* dynamic load net module

* export xxx_net

* add runpath

* link dl

* remove -ldl for macos

* fix rpath

* module -> shared

* set MMDEPLOY_DYNAMIC_BACKEND OFF when MMDEPLOY_BUILD_SDK_MONOLITHIC is OFF
lzhangzz pushed a commit that referenced this pull request Mar 3, 2023
@irexyc
[Feature] Dynamically load net module to remove dependencies of mmdep…
d95950d 
…loy.so (#1776) (#1822)

* dynamic load net module

* export xxx_net

* add runpath

* link dl

* remove -ldl for macos

* fix rpath

* module -> shared

* set MMDEPLOY_DYNAMIC_BACKEND OFF when MMDEPLOY_BUILD_SDK_MONOLITHIC is OFF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@lzhangzz lzhangzz lzhangzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irexyc @lzhangzz @lvhan028