Skip to content

Conversation

AllentDan
Copy link
Member

Fixed SAR exporting for TorchScript. Updated the status of SAR.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon changed the base branch from dev-1.x to main April 7, 2023 08:18
@RunningLeon
Copy link
Collaborator

@AllentDan Could you rebase to main branch? CI error is fixed on main branch.

@AllentDan AllentDan force-pushed the update-sar-status branch from 075b216 to 3f64fff Compare April 7, 2023 09:04
@RunningLeon
Copy link
Collaborator

could fix ci errors

@RunningLeon
Copy link
Collaborator

@AllentDan Could sync with latest main branch.

@RunningLeon RunningLeon added the documentation Improvements or additions to documentation label Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (58bcdae) 49.44% compared to head (6ef8a03) 49.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1789   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files         338      338           
  Lines       12920    12920           
  Branches     1897     1897           
=======================================
  Hits         6388     6388           
  Misses       6088     6088           
  Partials      444      444           
Flag Coverage Δ
unittests 49.44% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ebase/mmocr/models/text_recognition/sar_decoder.py 76.52% <0.00%> (ø)
...ebase/mmocr/models/text_recognition/sar_encoder.py 59.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 6c26e88 into open-mmlab:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants