Skip to content

Conversation

grimoire
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

MMCV has update the api of nms rotated, which broken our rewriter.
https://github.com/open-mmlab/mmcv/blob/2.x/mmcv/ops/nms.py

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@hanrui1sensetime hanrui1sensetime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UT still failed in CI, maybe need to check.

@lvhan028
Copy link
Collaborator

lvhan028 commented Mar 1, 2023

The UT still failed in CI, maybe need to check.

May merge dev-1.x latest to resolve backend-xxx workflow error, which has been fixed by PR #1810

@lvhan028
Copy link
Collaborator

lvhan028 commented Mar 3, 2023

UT still failed.
@AllentDan regarding the lint issue, should we update config or links in doc?

@AllentDan
Copy link
Member

Yes. @grimoire Could you please help me replace all https://github.com/open-mmlab/mmdeploy/blob/1.x/configs/mmdet/detection/detection_rknn_static-320x320.py with https://github.com/open-mmlab/mmdeploy/blob/1.x/configs/mmdet/detection/detection_rknn-int8_static-320x320.py in this PR?

@grimoire
Copy link
Member Author

grimoire commented Mar 3, 2023

@AllentDan Sure

@grimoire grimoire added the Bug:P1 label Mar 6, 2023
Copy link
Collaborator

@hanrui1sensetime hanrui1sensetime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lvhan028 lvhan028 merged commit 91a0a9a into open-mmlab:dev-1.x Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants