Skip to content

Conversation

lvhan028
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

#1720
"
In addition, there is a high security issue for onnx<1.13.0 but onnx==1.13.0 has dependency conflict w/ mmdeploy==0.12.0. I hope this issue also could be resolved soon.
"

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028 lvhan028 added the enhancement New feature or request label Feb 21, 2023
@lvhan028 lvhan028 requested review from grimoire and irexyc March 8, 2023 06:43
@lvhan028 lvhan028 added improvement Improvement and removed enhancement New feature or request labels Mar 9, 2023
@lvhan028 lvhan028 merged commit bace0a2 into open-mmlab:dev-1.x Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants