Skip to content

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Apr 3, 2023

Motivation

bump version to v1.0.0

Modification

Bump version to v1.0.0
Update docs for switching default branch to main

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon RunningLeon changed the title [Document]: Update docs for switching default branch [Document]: Update docs for main branch Apr 3, 2023
@irexyc
Copy link
Collaborator

irexyc commented Apr 3, 2023

A fix

diff --git a/tools/package_tools/test/test_sdk.sh b/tools/package_tools/test/test_sdk.sh
index 57e27de75..472a8d5b4 100755
--- a/tools/package_tools/test/test_sdk.sh
+++ b/tools/package_tools/test/test_sdk.sh
@@ -18,7 +18,7 @@ cp -r $test_pkg $work_dir
 pushd $work_dir

 # opencv
-if [[ ! -d $OpenCV_DIR ]]; then
+if [ ! -d "$OpenCV_DIR" ]; then
     ./install_opencv.sh
 fi

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0196cd0). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1960   +/-   ##
=======================================
  Coverage        ?   49.44%           
=======================================
  Files           ?      338           
  Lines           ?    12920           
  Branches        ?     1897           
=======================================
  Hits            ?     6388           
  Misses          ?     6088           
  Partials        ?      444           
Flag Coverage Δ
unittests 49.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lvhan028 lvhan028 requested review from grimoire, irexyc and lvhan028 and removed request for irexyc April 4, 2023 03:08
@RunningLeon RunningLeon requested review from grimoire and lvhan028 April 4, 2023 09:15
@RunningLeon RunningLeon changed the title [Document]: Update docs for main branch bump version to v1.0.0 Apr 4, 2023
@RunningLeon RunningLeon requested a review from lvhan028 April 4, 2023 14:48
@RunningLeon RunningLeon force-pushed the update_docs_main branch 7 times, most recently from 950b503 to 0f876f8 Compare April 5, 2023 12:50
@lvhan028 lvhan028 merged commit 4bb9bc7 into open-mmlab:main Apr 6, 2023
@RunningLeon RunningLeon deleted the update_docs_main branch April 6, 2023 09:51
huayuan4396 pushed a commit to huayuan4396/mmdeploy that referenced this pull request Apr 23, 2023
* change docs from 1.x to main

* bump version

* update readme status info and highlights

* revert version change

* fix dead links

* fix script

* fix docs

* fix building status

* fix md lint error

* upgrade to ubuntu20.04 for github ci

* Revert "upgrade to ubuntu20.04 for github ci"

This reverts commit 9c598f4.

* update codebase md files

* upgrade to ubuntu20.04 for github ci

* fix

* fix requirements

* fix

* fix ci

* bump version

* fix

* fix pplnn torchscript

* fix building status

* fix ncnn

* fix

* remove circileci hold

* fix pytorch image

mmcls -> mmpretrain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants