[Fix] swap width and height in Resize and Pad according to upstream codebases #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllentDan
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 339 339
Lines 12976 12976
Branches 1900 1900
=======================================
Hits 6450 6450
Misses 6077 6077
Partials 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@AllentDan CI of test mmpretrain full pipeline failed. |
irexyc
requested changes
May 11, 2023
irexyc
approved these changes
May 11, 2023
3 tasks
3 tasks
irexyc
reviewed
Jun 14, 2023
Comment on lines
86
to
+87
| data["pad_fixed_size"].push_back(size_[1]); | ||
| data["pad_fixed_size"].push_back(size_[0]); |
There was a problem hiding this comment.
pad_fixed_size seems to be in (w,h) format, although it is not used elsewhere
There was a problem hiding this comment.
That's weird. In mmcv's document, pad_shape is formed with (height, width) which should be self.size here.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mmcv.readthedocs.io/en/2.x/understand_mmcv/data_transform.html