[Feature] Add typehint to mmdet3d/models/backbones.#2464
Merged
JingweiZhang12 merged 18 commits intoopen-mmlab:dev-1.xfrom May 11, 2023
Lum1104:Lum1104/add_typehint
Merged
[Feature] Add typehint to mmdet3d/models/backbones.#2464JingweiZhang12 merged 18 commits intoopen-mmlab:dev-1.xfrom Lum1104:Lum1104/add_typehint
JingweiZhang12 merged 18 commits intoopen-mmlab:dev-1.xfrom
Lum1104:Lum1104/add_typehint
Conversation
Registry docs are now under Advanced Tutorials.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2464 +/- ##
===========================================
+ Coverage 47.14% 47.17% +0.03%
===========================================
Files 276 276
Lines 22979 23032 +53
Branches 3569 3582 +13
===========================================
+ Hits 10833 10866 +33
- Misses 11464 11484 +20
Partials 682 682
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Xiangxu-0103
requested changes
Apr 25, 2023
Collaborator
Xiangxu-0103
left a comment
There was a problem hiding this comment.
Please use more standardized and appropriate typehints, you can take other modules as references.
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Xiangxu-0103
reviewed
May 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add typehint to the code and make it more readable.
Checklist