This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Bring missing osc/rdma fixes to v2.x #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typo caused SEGVs on systems with only fetching atomic support. Fixes open-mpi/ompi#1329 Signed-off-by: Nathan Hjelm <[email protected]> (cherry picked from open-mpi/ompi@a19c265) Signed-off-by: Nathan Hjelm <[email protected]>
This commit fixes the following: - CIDs 1328491, 1328492: Dead code caused by typos in a prior commit. - Fix the calculation of dynamic memory regions. This was causes incorrect RMA range errors when accessing the last partial page of an attachment. - Fix a SEGV when using dynamic memory windows with local state (all processes on the same node). Signed-off-by: Nathan Hjelm <[email protected]> (cherry picked from open-mpi/ompi@97c9732) Signed-off-by: Nathan Hjelm <[email protected]>
|
Test PASSed. |
|
@hjelmn Is this critical for v2.0.0? If so, please mark it with the "blocker" label. |
|
:bot🏷️blocker |
|
@sjeaugey Please review for v2.0.0. |
|
👍 |
|
@hppritcha Good to go |
hppritcha
added a commit
that referenced
this pull request
Mar 11, 2016
Bring missing osc/rdma fixes to v2.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits fixed bugs found by MTT on master. They were intended for the v2.x branch but were never brought over. Fixes a failure on nvidia MTT.
See open-mpi/ompi#1427 for a typical backtrack. Ignore the title of the bug though as this has nothing to do with MPI_Aint.
:bot:assign: @sjeaugey
:bot🏷️bug
:bot:milestone:v2.0.0