v5.0.x: Define the object class for the isendrecv request once. #10102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch works, but the code is ugly, each file using a static structure and function which ends up being defined twice (for MPI and PMPI API). There is no better solution at the MPI API level that would not require adding additional files to move the structure declaration, callback implementations and the class implementation into. Signed-off-by: George Bosilca <[email protected]> (cherry picked from commit 369754d)
bosilca
approved these changes
Mar 9, 2022
awlauria
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch works, but the code is ugly, each file using a static
structure and function which ends up being defined twice (for MPI and
PMPI API). There is no better solution at the MPI API level that would
not require adding additional files to move the structure declaration,
callback implementations and the class implementation into.
Signed-off-by: George Bosilca [email protected]
(cherry picked from commit 369754d)
This is the v5.0.x PR for #9990. Without it, you cannot build successfully on MacOS.