orterun: allow DDT if options contain :'s #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in MPMD detection that disables totalview if a : is found anywhere on the command line. This includes inside an argument option or MCA variable value. This commit changes the check to look for the string " : " instead of the character : which should eliminate the issue in most cases. Signed-off-by: Nathan Hjelm <[email protected]>
Contributor
|
👍 |
Member
Author
|
Build started before the XRC fix went into master. |
hjelmn
added a commit
that referenced
this pull request
Feb 19, 2016
orterun: allow DDT if options contain :'s
Member
|
Please open a pr on v2.x and if needed v1.10 |
Member
Author
|
Yup. This should go into 1.10.3 but can wait for 2.0.1 as it affect launching the debugger with mpirun -debug |
Member
Author
|
Will open the PRs after I track down the remaining XRC issue :). |
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
v2.x: Eliminate the litter problem by moving the PMIx connection point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in MPMD detection that disables totalview if a : is
found anywhere on the command line. This includes inside an argument
option or MCA variable value. This commit changes the check to look
for the string " : " instead of the character : which should eliminate
the issue in most cases.
Signed-off-by: Nathan Hjelm [email protected]