Skip to content

mpool/hugepage: set mntent API instead of manually parsing /proc/mounts #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

ggouaillardet
Copy link
Contributor

Refs #1822

@ggouaillardet
Copy link
Contributor Author

@hjelmn is hugetlbfs upported by Open MPI on OS X ?
in other words, is it ok to disqualify this module if mntent is not available ?

@hppritcha
Copy link
Member

I plan to open a PR for the Cray large page support this week.

The manual parsing doesn't work reliably on CLE 6

Am Montag, 4. Juli 2016 schrieb Gilles Gouaillardet :

@hjelmn https://github.com/hjelmn is hugetlbfs upported by Open MPI on
OS X ?
in other words, is it ok to disqualify this module if mntent is not
available ?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1846 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AHdNqiF1o4s63jLhXhnmR5_gC30WFdZgks5qSOiPgaJpZM4JEI5P
.

@hjelmn
Copy link
Member

hjelmn commented Jul 5, 2016

@ggouaillardet OS X has hugepage support using an mmap flag. Problem is that I have not been able to reliably allocate huge pages more than 5 min after a boot. It looks like Apple only allows huge page allocation in a pool that is very quickly exhausted.

@ggouaillardet
Copy link
Contributor Author

@hjelmn i found that there is no /proc/mounts on osx (at least by default on Yosemite) so #ifdef HAVE_MNTENT_H protecting the subroutine body does not alter the behavior (at least on osx)

if you are fine with that, i will merge this PR

@hppritcha
Copy link
Member

@hjelmn i think this needs to be checked on a Cray if in fact you'd like the huge page mpool to work on that system.

@hppritcha
Copy link
Member

This fix is needed for Cray KNL systems (or more precisely CLE 6) otherwise we see fairly frequent aborts in MPI_Init (unless one is using ofi mtl). So putting this at milestone 2.0.1.

@hppritcha hppritcha added this to the v2.0.1 milestone Jul 26, 2016
@hppritcha hppritcha self-assigned this Jul 26, 2016
@hppritcha
Copy link
Member

@ggouaillardet I'm going to merge this and test the cherry pick on 2.x. Unfortunately native launch is aprun on KNL nodes is all messed up on master.

@hppritcha hppritcha merged commit 477f6cb into open-mpi:master Aug 1, 2016
hppritcha added a commit to hppritcha/ompi that referenced this pull request Aug 2, 2016
On Cray, PR open-mpi#1846 introduced a double free
situation which led to all kinds of random memory
corruption problems.

This commit fixes this problem.

Signed-off-by: Howard Pritchard <[email protected]>
hjelmn pushed a commit to hjelmn/ompi that referenced this pull request Sep 13, 2016
On Cray, PR open-mpi#1846 introduced a double free
situation which led to all kinds of random memory
corruption problems.

This commit fixes this problem.

Signed-off-by: Howard Pritchard <[email protected]>
hjelmn pushed a commit to hjelmn/ompi that referenced this pull request Sep 21, 2016
On Cray, PR open-mpi#1846 introduced a double free
situation which led to all kinds of random memory
corruption problems.

This commit fixes this problem.

Signed-off-by: Howard Pritchard <[email protected]>
bosilca pushed a commit to bosilca/ompi that referenced this pull request Oct 3, 2016
On Cray, PR open-mpi#1846 introduced a double free
situation which led to all kinds of random memory
corruption problems.

This commit fixes this problem.

Signed-off-by: Howard Pritchard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants