Skip to content

ompi_wrapper_script: fix $extra_ldflags #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ggouaillardet
Copy link
Contributor

use @OMPI_PKG_CONFIG_LDFLAGS@ instead of @OMPI_WRAPPER_EXTRA_LDFLAGS@
so @{libdir} is substitued with ${libdir}

Thanks Manesh Nanavalla for the report

(cherry picked from commit cb76d93)

use @OMPI_PKG_CONFIG_LDFLAGS@ instead of @OMPI_WRAPPER_EXTRA_LDFLAGS@
so @{libdir} is substitued with ${libdir}

Thanks Manesh Nanavalla for the report

(cherry picked from commit open-mpi/ompi@cb76d93)
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Signed-off-by line to this PR's commit.

@jsquyres jsquyres modified the milestones: v2.1.0, v2.1.1 Feb 27, 2017
@hppritcha hppritcha modified the milestones: v2.1.2, v2.1.1 Apr 24, 2017
@hppritcha hppritcha modified the milestones: v2.1.3, v2.1.2 Aug 9, 2017
@jsquyres
Copy link
Member

jsquyres commented Jan 9, 2018

We closed the v2.0.x version of this PR without merging (#2250). Closing this one without merging, too (looks like it made it into the v3.0.x release series).

@jsquyres jsquyres closed this Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants