rcache/vma: do not release vma stuctures in vma_tree_delete #2719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a deadlock that can occur when the libc version holds a lock when calling munmap. In this case we could end up calling free() from vma_tree_delete which would in turn try to obtain the lock in libc. To avoid the issue put any deleted vma's in a new list on the vma module and release them on the next call to vma_tree_insert. This should be safe as this function is not called from the memory hooks. Backported from 79cabc9 Fixes open-mpi#1654 Signed-off-by: Nathan Hjelm <[email protected]>
jsquyres
reviewed
Jan 12, 2017
|
|
||
| while (NULL != (item = opal_list_remove_first (&rcache->vma_gc_list))) { | ||
| OBJ_RELEASE(item); | ||
| } |
There was a problem hiding this comment.
Any reason not to use OPAL_LIST_DESTRUCT here?
Or is it just to-MAY-to vs. to-MAH-to?
There was a problem hiding this comment.
Would then need to OBJ_CONSTRUCT again. So its MAY to MAH.
jsquyres
approved these changes
Jan 12, 2017
|
@Di0gen @jladd-mlnx The reliability of the Mellanox jenkins has been quite low recently -- a lot of triggered builds that never start (like the current status of this PR):
Can something be fixed? Thanks! |
|
seems bug in jenkins, we are checking offline |
|
@hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a deadlock that can occur when the libc version
holds a lock when calling munmap. In this case we could end up calling
free() from vma_tree_delete which would in turn try to obtain the lock
in libc. To avoid the issue put any deleted vma's in a new list on the
vma module and release them on the next call to vma_tree_insert. This
should be safe as this function is not called from the memory hooks.
Backported from 79cabc9
Fixes #1654
Signed-off-by: Nathan Hjelm [email protected]