v2.0.x: hwloc: re-enable use of autogen.pl in a tarball #3199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit fec519a broke the ability to run autogen.pl in a distribution tarball. This commit restores that ability by also distributing opal/mca/hwloc/autogen.options in the tarball. Skipping CI because CI does not test this functionality: [skip ci] bot:notest Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit b8dfd49)
hppritcha
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fec519a on master broke the ability to run autogen.pl in a distribution tarball. This commit restores that ability by also distributing opal/mca/hwloc/autogen.options in the tarball.
Skipping CI because CI does not test this functionality:
[skip ci]
bot:notest
Signed-off-by: Jeff Squyres [email protected]
(cherry picked from commit b8dfd49)
@hppritcha This was causing failures in Cisco's MTT, such as https://mtt.open-mpi.org/index.php?do_redir=2407 (I have an MPI install that invokes
autogen.plin the tarball before the normalconfigure; make install). This regression is not in a released tarball yet. It was merged in #3066 on v2.x after v2.0.2 and before v2.0.3. The regression came in while fixing--with-hwloc=external, which was fec519a on master, and #3066 / commit 40e6b1f on v2.x.