Fix issue where path in walk would get mutated#7657
Merged
anderseknert merged 1 commit intoopen-policy-agent:mainfrom Jun 4, 2025
Merged
Fix issue where path in walk would get mutated#7657anderseknert merged 1 commit intoopen-policy-agent:mainfrom
walk would get mutated#7657anderseknert merged 1 commit intoopen-policy-agent:mainfrom
Conversation
I'm still not sure where this mutation occurs, as the append operation done in `walk` returns a copy and shouldn't mutate. But at least creating a shallow copy rather than a slice fixes the issue, and is still quite performant compared to the previous implementation that did a deep-copy of the path in each iteration. Fixes open-policy-agent#7656 Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
approved these changes
Jun 4, 2025
johanfylling
pushed a commit
to johanfylling/opa
that referenced
this pull request
Jun 4, 2025
) I'm still not sure where this mutation occurs, as the append operation done in `walk` returns a copy and shouldn't mutate. But at least creating a shallow copy rather than a slice fixes the issue, and is still quite performant compared to the previous implementation that did a deep-copy of the path in each iteration. Fixes open-policy-agent#7656 Signed-off-by: Anders Eknert <anders@styra.com> (cherry picked from commit 9d0557b)
johanfylling
pushed a commit
that referenced
this pull request
Jun 4, 2025
I'm still not sure where this mutation occurs, as the append operation done in `walk` returns a copy and shouldn't mutate. But at least creating a shallow copy rather than a slice fixes the issue, and is still quite performant compared to the previous implementation that did a deep-copy of the path in each iteration. Fixes #7656 Signed-off-by: Anders Eknert <anders@styra.com> (cherry picked from commit 9d0557b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still not sure where this mutation occurs, as the append operation done in
walkreturns a copy and shouldn't mutate. But at least creating a shallow copy rather than a slice fixes the issue, and is still quite performant compared to the previous implementation that did a deep-copy of the path in each iteration.Fixes #7656