Replace gorilla/mux dependency with http.ServeMux#7676
Merged
anderseknert merged 1 commit intoopen-policy-agent:mainfrom Jun 9, 2025
Merged
Replace gorilla/mux dependency with http.ServeMux#7676anderseknert merged 1 commit intoopen-policy-agent:mainfrom
anderseknert merged 1 commit intoopen-policy-agent:mainfrom
Conversation
anderseknert
force-pushed
the
http-servemux
branch
from
c3e2a5f to
2869075
Compare
sspaink
approved these changes
Jun 9, 2025
I was curious to see how much work this would entail, and it turned out to be... some :) Particularly porting some of the features exposed as settings by gorilla mux, like removing trailing slashes, or escaping `/` in matched paths. This change is breaking by necessity, as some public functions previously accepted arguments straight from the mux library. I don't really see any way around that if we want to get rid of the dependency. I don't think that too many external projects use code from the server directly though, so I'm thinking the impact should be minimal? Happy to hear what others think. Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
http-servemux
branch
from
2869075 to
85a9d11
Compare
Contributor
|
I'm attempting to update to the 1.6.0 release and find that without mux's |
Contributor
|
@deeglaze hey there! You're not alone, I've become aware of this recently, too. To improve the situation without going back to gorilla/mux, we've got #7789 now. It'll be part of the next release. Please let me know if it's sufficient for your use case or if it's not covering it. Sorry for the inconvenience 😉 |
Merged
Contributor
|
That was wildly fast. I can confirm this works for me. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was curious to see how much work this would entail, and it turned out to be... some :) Particularly porting some of the features exposed as settings by gorilla mux, like removing trailing slashes, or escaping
/in matched paths.This change is breaking by necessity, as some public functions previously accepted arguments straight from the mux library. I don't really see any way around that if we want to get rid of the dependency. I don't think that too many external projects use code from the server directly though, so I'm thinking the impact should be minimal? Happy to hear what others think.