loader: pass bundle name in AsBundle()#7798
Merged
srenatus merged 1 commit intoopen-policy-agent:mainfrom Jul 24, 2025
Merged
Conversation
It seems correct to give the bundle a name, after all. It's just metadata. Signed-off-by: Stephan Renatus <stephan@styra.com>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
johanfylling
approved these changes
Jul 24, 2025
| WithRegoVersion(fl.opts.RegoVersion) | ||
| WithRegoVersion(fl.opts.RegoVersion). | ||
| WithLazyLoadingMode(fl.bundleLazyLoading). | ||
| WithBundleName(path) |
Contributor
There was a problem hiding this comment.
This only affects module paths, right, so data paths are preserved?
But since this affects the bundle path that's then used for creating bundles, e.g. in opa build, wouldn't this mean that this path prefix would now end up in the produced bundle? This isn't necessarily bad, as it might even take care of possible collisions when loading multiple bundle paths at once (might currently be resolved some other way, though). But it is a structural change to produced bundles, which could be considered breaking (at least enough so we should remember to make note of it in the changelog).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems correct to give the bundle a name, after all. It's just metadata.