Skip to content

labels: aggregate from package/document scope, update CHANGELOG#8633

Merged
srenatus merged 1 commit into
open-policy-agent:mainfrom
srenatus:sr/zmunslxvnzpq
May 11, 2026
Merged

labels: aggregate from package/document scope, update CHANGELOG#8633
srenatus merged 1 commit into
open-policy-agent:mainfrom
srenatus:sr/zmunslxvnzpq

Conversation

@srenatus
Copy link
Copy Markdown
Contributor

Small follow-up to #8613. I think carrying the labels from upper scopes along makes this more powerful.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 11, 2026

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 5c7e99f
🔍 Latest deploy log https://app.netlify.com/projects/openpolicyagent/deploys/6a01c49706d0370008b8f593
😎 Deploy Preview https://deploy-preview-8633--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@johanfylling johanfylling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread docs/docs/policy-language.md Outdated
are both collected.
rule (or document, or package). When rules with `labels` are successfully
evaluated, their label sets are automatically recorded in decision log events
under the `rule_labels` field. Labels from package-scoped, document-scoped,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for why we're leaving out the subpackages scope?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about it. That's the only reason. Will update, as it seems to make sense.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@srenatus srenatus enabled auto-merge (rebase) May 11, 2026 11:41
…GELOG

Small follow-up to open-policy-agent#8613. I think carrying the labels from upper scopes
along makes this more powerful.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
@srenatus srenatus merged commit 9137391 into open-policy-agent:main May 11, 2026
40 checks passed
@srenatus srenatus deleted the sr/zmunslxvnzpq branch May 11, 2026 12:10
@github-actions
Copy link
Copy Markdown

Benchmark Regression Detected

Commit 913739161ba6222428802d3dbe9c895c9d3d6658 introduced benchmark regressions (threshold: >25% ns/op increase).

Package Benchmark Regression
v1/ast BenchmarkFromBuiltinNames/two_parts-4 +154%
v1/types BenchmarkAnyMergeOne/5000-4 +136%
v1/types BenchmarkAnyUnionAllUniqueTypes/1000x500-4 +105%
v1/types BenchmarkAnyUnionAllUniqueTypes/500x250-4 +84%
v1/types BenchmarkAnyUnionAllUniqueTypes/100x1000-4 +83%
v1/types BenchmarkAnyUnionAllUniqueTypes/500x1000-4 +64%
v1/ast BenchmarkIsVarCompatibleString/incompatible_last_char!-4 +63%
v1/types BenchmarkAnyUnionAllUniqueTypes/250x1000-4 +52%
v1/types BenchmarkAnyUnionAllUniqueTypes/1000x250-4 +43%
v1/types BenchmarkAnyUnionAllUniqueTypes/100x100-4 +42%
v1/types BenchmarkAnyUnionAllUniqueTypes/1000x2500-4 +42%
v1/types BenchmarkAnyUnionAllUniqueTypes/500x2500-4 +41%
v1/types BenchmarkAnyUnionAllUniqueTypes/500x500-4 +35%
v1/types BenchmarkAnyUnionAllUniqueTypes/2500x100-4 +32%
v1/types BenchmarkAnyUnionAllUniqueTypes/2500x1000-4 +32%
v1/ast BenchmarkIsVarCompatibleString/__really_long_variable_name_1234567890-4 +31%
v1/types BenchmarkAnyUnionAllUniqueTypes/2500x250-4 +31%
v1/types BenchmarkAnyUnionAllUniqueTypes/100x2500-4 +31%
v1/types BenchmarkAnyMergeOne/1000-4 +29%
v1/types BenchmarkAnyUnionAllUniqueTypes/250x2500-4 +29%
v1/types BenchmarkAnyUnionAllUniqueTypes/2500x2500-4 +28%
v1/rego BenchmarkPartialObjectRuleCrossModule/1000-4 +27%

Benchmarks Dashboard

This comment was automatically generated by the benchmarks workflow.

@srenatus
Copy link
Copy Markdown
Contributor Author

Meh all that is noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants