Fix unnecessary-some rule not working after OPA 1.0+#1485
Merged
anderseknert merged 1 commit intomainfrom Apr 14, 2025
Merged
Conversation
And a few tweaks to the import checking functions. Fixes #1483 Signed-off-by: Anders Eknert <anders@styra.com>
| count(pv) == count(path) | ||
|
|
||
| _arr(imp) == path | ||
| every i, part in path { |
Contributor
There was a problem hiding this comment.
Does this run any faster/slower than building an array and using ==?
Member
Author
There was a problem hiding this comment.
Potentially, as every can benefit from early exit. But it's mostly custom functions that is a win to avoid when they're not strictly needed.
Member
Author
There was a problem hiding this comment.
(although this is not a hot path.. I just thought the change made the code nicer :)
charlieegan3
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And a few tweaks to the import checking functions.
Fixes #1483