lsp/uri: Refactor URI handling#1644
Merged
charlieegan3 merged 1 commit intoopen-policy-agent:mainfrom Aug 5, 2025
Merged
Conversation
charlieegan3
force-pushed
the
to-path-refactor
branch
2 times, most recently
from
587594e to
b9fcd6f
Compare
anderseknert
approved these changes
Aug 5, 2025
| path, hadPrefix := strings.CutPrefix(uri, "file://") | ||
| if hadPrefix { | ||
| // if it looks like a URI, then try and decode it | ||
| if decodedPath, err := url.QueryUnescape(path); err == nil { |
Member
There was a problem hiding this comment.
Why change this? 🙂 Seems like CutPrefix answers the same question in one function call instead of two, no?
Contributor
Author
There was a problem hiding this comment.
yeah that makes sense. I'll keep that in there!
Member
There was a problem hiding this comment.
This should probably not be here
Contributor
Author
There was a problem hiding this comment.
yeah I thought so too, so I've removed it?
This had been botched some time back and can be made simpler. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
to-path-refactor
branch
from
b9fcd6f to
656c254
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had been botched some time back and can be made simpler.