fix: Prefer-Equals-Comparison Edge Case With Multiple "="#1824
Merged
charlieegan3 merged 3 commits intoopen-policy-agent:mainfrom Jan 13, 2026
Conversation
…same line of the prefer-equals comparison violation Signed-off-by: Sean Ledford <s_ledford@apple.com>
Signed-off-by: Sean Ledford <s_ledford@apple.com>
SeanLedford
force-pushed
the
s_ledford/prefer-equals-comparison-multiple-eq-edge-case
branch
from
032eb21 to
8c1850d
Compare
charlieegan3
approved these changes
Jan 13, 2026
Contributor
charlieegan3
left a comment
charlieegan3
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me! nice to have the test too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #1818, where the prefer-equals comparison fixer would replace the wrong "=" when fixing the violation. Now correctly targets the expression that is given via the violation location.