Various AST transform improvements#1892
Merged
anderseknert merged 1 commit intoopen-policy-agent:mainfrom Feb 25, 2026
Merged
Conversation
srenatus
changed the title
srenatus
approved these changes
Feb 25, 2026
|
|
||
| for i, comment := range mod.Comments { | ||
| encoded := base64.StdEncoding.EncodeToString(comment.Text) | ||
| encoded := "IE1FVEFEQVRB" // " METADATA" |
Member
Author
There was a problem hiding this comment.
Hah! Like 500+ of them in Regal alone :P
| value := ast.NewObjectWithCapacity(1 + | ||
| min(1, len(mod.Imports)) + | ||
| min(1, len(mod.Rules)) + | ||
| min(1, len(mod.Comments)), |
Contributor
There was a problem hiding this comment.
I see what you did there... OK... Perhaps this would warrant a small (to-be-inlined) helper?
func selector[T ~[]](s T) int { // 1 or 0
return min(1, len(T))
}(untested)
Member
Author
There was a problem hiding this comment.
I'm already well over my time budget, but noted for the next round 👍
Reduce allocations, fix some TODOs, and so on. Not much to see, just me doing anything but work on what I'm supposed to work on. Signed-off-by: Anders Eknert <anders.eknert@apple.com>
anderseknert
force-pushed
the
transform-fixes
branch
from
0c3a998 to
d7dbf7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce allocations, fix some TODOs, and so on. Not much to see, just me doing anything but work on what I'm supposed to work on.