Include rule docs links in metadata#1935
Merged
anderseknert merged 1 commit intoopen-policy-agent:mainfrom Apr 7, 2026
Merged
Conversation
This makes rules more self-contained / declarative, and will benefit a future "regodoc" renderer. Related to that, also replace use of config.docs.resolve_url in tests in favor of static URLs. Dynamically resolving doc URLs wasn't ever needed tbh, and having tests compare against static data feels much better. Also some style fixes to unify how location data is presented in tests. While there are many changes here, it's mostly repeating the same changes everywhere, so don't spend much time reviewing this. Fixes open-policy-agent#1927 Signed-off-by: Anders Eknert <anders.eknert@apple.com>
charlieegan3
approved these changes
Apr 7, 2026
Member
Author
|
It would have been nice to wipe config.docs.resolve_url, but since it's been mentioned in the custom rules docs, there are likely users that depend on it. |
Merged
via the queue into
open-policy-agent:main
with commit Apr 7, 2026
6fd115a
11 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes rules more self-contained / declarative, and will benefit a future "regodoc" renderer. Related to that, also replace use of config.docs.resolve_url in tests in favor of static URLs. Dynamically resolving doc URLs wasn't ever needed tbh, and having tests compare against static data feels much better.
Also some style fixes to unify how location data is presented in tests.
While there are many changes here, it's mostly repeating the same changes everywhere, so don't spend much time reviewing this.
Fixes #1927