cheats/rules: Refactor into partial object and set rules + Rename to newer terminology#9
Merged
philipaconrad merged 6 commits intomainfrom Mar 5, 2025
Merged
Conversation
This commit splits partial set and object rules into their own sections. Signed-off-by: Philip Conrad <philip@chariot-chaser.net>
anderseknert
approved these changes
Mar 5, 2025
Member
anderseknert
left a comment
anderseknert
left a comment
There was a problem hiding this comment.
LGTM, although I don't think we should import rego.v1 in any new examples. We should also consider how we name these rule types, but leaving it at your discretion.
charlieegan3
reviewed
Mar 5, 2025
Contributor
There was a problem hiding this comment.
This generated PDF looks a bit wonky but we can come back to that once this is in.
charlieegan3
approved these changes
Mar 5, 2025
Contributor
charlieegan3
left a comment
charlieegan3
left a comment
There was a problem hiding this comment.
Thanks for working on this!
This commit refactors the naming scheme for complete/partial rules to be the more modern single/multi-value terminology. Also included: Notes about the older terminology that still appears in docs and learning materials. Signed-off-by: Philip Conrad <philip@chariot-chaser.net>
philipaconrad
changed the title
Signed-off-by: Philip Conrad <philip@chariot-chaser.net>
Signed-off-by: Philip Conrad <philip@chariot-chaser.net>
Member
Author
|
ℹ️ In keeping with the discussion we had in Slack, I've refactored how we name the rule types:
I've also added some short notes about "In older documentation..." describing the older naming scheme. |
Signed-off-by: Philip Conrad <philip@chariot-chaser.net>
Signed-off-by: Philip Conrad <philip@chariot-chaser.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR splits partial set and object rules into their own sections, and refactors the naming scheme from "partial" and "complete" rules to multi-value and single-value rules, respectively. I've included some short notes about the older terminology too.