-
Notifications
You must be signed in to change notification settings - Fork 661
Zeroize memory in SHA3 implementation #2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aiden Fox Ivey <[email protected]>
Signed-off-by: Aiden Fox Ivey <[email protected]>
SWilson4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aidenfoxivey!
|
Sounds good to me @SWilson4 - anything I can do further wrt this issue? (or the broader one) |
Based on Douglas's assessment in #2163, I'd say the next work would be either sntrup or McEliece—you could take a look at patching that code to clear secret values. However, I'd expect this to take quite a bit longer and to require some analysis to figure out exactly what needs to be cleared. |
Sounds good - I’ll take a look at McEliece to start. |
|
Woohoo! |
Added a method to do aligned but also zeroed out freeing of context. Used this method within the liboqs's SHA3 implementation.
Doesn't quite fix all of 2163, but is a start.
No.
No.