Skip to content

Conversation

@Yadunund
Copy link
Member

@Yadunund Yadunund commented Jun 6, 2023

Merge commit instead of squash merge.

note: we should consider dropping the VERSION in CMakeLists.txt or atleast only specify a major version.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #101 (5f3d88d) into main (7c38cdb) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   23.01%   23.02%           
=======================================
  Files         369      369           
  Lines       30769    30769           
  Branches    14371    14371           
=======================================
+ Hits         7083     7085    +2     
- Misses      14203    14234   +31     
+ Partials     9483     9450   -33     
Flag Coverage Δ
tests 22.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

@mxgrey mxgrey merged commit 19d0c90 into main Jun 6, 2023
@mxgrey mxgrey deleted the yadu/3.1.0 branch June 6, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants