-
Notifications
You must be signed in to change notification settings - Fork 1.8k
WIP: update code to use otelconf v1.0 schema #14184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: update code to use otelconf v1.0 schema #14184
Conversation
|
Note I'm substituting the otelconf import to my fork to use the changes in the pull request i have open upstream |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
The go implementation of the release candidate for opentelemetry-configuration schema is still under review in otel-go-contrib. This work is too update our internal dependency to use this release candidate. Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
fc719aa to
6a2f183
Compare
CodSpeed Performance ReportMerging #14184 will degrade performances by 29.68%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ❌ | BenchmarkTraceSizeBytes |
309 µs | 439.4 µs | -29.68% |
| ❌ | BenchmarkLogsToProto2k |
45 µs | 63.4 µs | -29.07% |
| ❌ | BenchmarkTracesToProto2k |
69 µs | 97 µs | -28.83% |
Footnotes
-
20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
The go implementation of the release candidate for opentelemetry-configuration schema is still under review in otel-go-contrib. This work is too update our internal dependency to use this release candidate.
See open-telemetry/opentelemetry-go-contrib#8026 for more details