Skip to content

Conversation

@codeboten
Copy link
Contributor

The go implementation of the release candidate for opentelemetry-configuration schema is still under review in otel-go-contrib. This work is too update our internal dependency to use this release candidate.

See open-telemetry/opentelemetry-go-contrib#8026 for more details

@codeboten codeboten requested a review from a team as a code owner November 18, 2025 19:27
@codeboten codeboten requested a review from songy23 November 18, 2025 19:27
@codeboten codeboten marked this pull request as draft November 18, 2025 19:27
@codeboten
Copy link
Contributor Author

Note I'm substituting the otelconf import to my fork to use the changes in the pull request i have open upstream

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 3, 2025
The go implementation of the release candidate for opentelemetry-configuration schema is still under review in otel-go-contrib. This work is too update our internal dependency to use this release candidate.

Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/add-otelconf-v1 branch from fc719aa to 6a2f183 Compare December 10, 2025 19:36
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025

CodSpeed Performance Report

Merging #14184 will degrade performances by 29.68%

Comparing codeboten:codeboten/add-otelconf-v1 (31974bf) with main (2e5bb6d)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 3 regressions
✅ 56 untouched
⏩ 20 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BenchmarkTraceSizeBytes 309 µs 439.4 µs -29.68%
BenchmarkLogsToProto2k 45 µs 63.4 µs -29.07%
BenchmarkTracesToProto2k 69 µs 97 µs -28.83%

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
@github-actions github-actions bot removed the Stale label Dec 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant