Skip to content

chore: update trace based tests to test stream events#1072

Merged
cartersocha merged 7 commits intoopen-telemetry:mainfrom
danielbdias:update/trace-based-tests-to-test-stream-events
Aug 30, 2023
Merged

chore: update trace based tests to test stream events#1072
cartersocha merged 7 commits intoopen-telemetry:mainfrom
danielbdias:update/trace-based-tests-to-test-stream-events

Conversation

@danielbdias
Copy link
Copy Markdown
Contributor

@danielbdias danielbdias commented Aug 21, 2023

Changes

This PR adds more validations to the Checkout service and the Frontend service to consider the events that are produced and consumed in Kafka. With that, we can guarantee that the Accountability and Fraud Detection services are properly working and consuming orders.

Also, we are updating the trace-based tests to remove some deprecation notices about test namings definitions that changed (transactions are test suites, and environments are variable sets).

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@danielbdias danielbdias requested a review from a team August 21, 2023 12:13
@julianocosta89
Copy link
Copy Markdown
Member

Hey @danielbdias could you fix the yamllint issue and add a changelog?

@danielbdias
Copy link
Copy Markdown
Contributor Author

@julianocosta89 sure! I'm adding it on commit ae153bc .

Copy link
Copy Markdown
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha
Copy link
Copy Markdown
Contributor

Thanks Daniel

@cartersocha cartersocha merged commit d7b8070 into open-telemetry:main Aug 30, 2023
styblope pushed a commit to instana/opentelemetry-demo that referenced this pull request Sep 13, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
mohamed3637 added a commit to mohamed3637/opentelemetry-demo that referenced this pull request Oct 7, 2025
cloud-hb pushed a commit to cloud-hb/opentelemetry-demo that referenced this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants