fix: pass proper env var to tracetesting Dockerfile#1283
Merged
puckpuck merged 4 commits intoopen-telemetry:mainfrom Dec 6, 2023
Merged
fix: pass proper env var to tracetesting Dockerfile#1283puckpuck merged 4 commits intoopen-telemetry:mainfrom
puckpuck merged 4 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
hi @julianocosta89 and @mviitane ! talking with Tracetest team, we believe that this issue caused some of the problems that you had on #1273. @jorgeepc can you add an entry on the CHANGELOG with this change? |
puckpuck
approved these changes
Dec 3, 2023
Contributor
puckpuck
left a comment
puckpuck
left a comment
There was a problem hiding this comment.
Small nit about the order of changelog entries, but otherwise LGTM.
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
mohamed3637
added a commit
to mohamed3637/opentelemetry-demo
that referenced
this pull request
Oct 7, 2025
cloud-hb
pushed a commit
to cloud-hb/opentelemetry-demo
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the CLI version in
test/tracetesting/Dockerfileto use the env variable that was added as part of #1239. This guarantees the use of the same image version for the tracetest server and CLI in the trace-based process.Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.