Skip to content

[chore]: make stop target for all profiles #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinlparker merged 7 commits into from
Mar 7, 2024
Merged

[chore]: make stop target for all profiles #1427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d81113b
stop does all profiles
puckpuck Mar 2, 2024
32ad4c1
stop does all profiles
puckpuck Mar 2, 2024
4540f78
Merge branch 'main' into chore.fix-make-stop-target
puckpuck Mar 2, 2024
185d3da
fix stop target
puckpuck Mar 2, 2024
e50f79f
Merge remote-tracking branch 'origin/chore.fix-make-stop-target' into…
puckpuck Mar 2, 2024
8cf9ff9
Merge branch 'main' into chore.fix-make-stop-target
puckpuck Mar 3, 2024
75b7dee
Merge branch 'main' into chore.fix-make-stop-target
austinlparker Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ the release.
([#1406](https://github.com/open-telemetry/opentelemetry-demo/pull/1406))
* [CartService] - Add Host Detector
([#1415](https://github.com/open-telemetry/opentelemetry-demo/pull/1415))
* [chore] - add tests and odd profiles to make stop
([#1427](https://github.com/open-telemetry/opentelemetry-demo/pull/1427))

## 1.8.0

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ start-odd:

.PHONY: stop
stop:
docker compose down --remove-orphans --volumes
docker compose --profile tests --profile odd down --remove-orphans --volumes
@echo ""
@echo "OpenTelemetry Demo is stopped."

Expand Down