enhance productcatalogservice tracing support: add attributes to existing spans#143
Conversation
…ting spans Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
|
@cartersocha will you help review this? |
julianocosta89
left a comment
There was a problem hiding this comment.
Hello @fatsheep9146, could you add some extra attributes?
And also some events?
Absolutely :) |
|
I'd like to see the ListProducts and SearchProducts handlers with additional attributes as well. We can add the total products returned to both, and the search query to the latter. |
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
|
ping @puckpuck @julianocosta89 for review. I've added more attributes and events. Please help to review this, thanks :) |
|
@fatsheep9146 please update the issue to reflect your changes. Merging now 🦑 |
@cartersocha I saw that you closed the issue #50. I think the issue is not ready to be closed, there are still several features needed to be resolved. |
|
I think the merge automatically closed the issue. I just re-opened it. I agree it’s not done yet! 🧜🏻♂️ |

fix #50
I'm trying to fix
Changes
Adds attributes to existing span in GetProduct handler.