Skip to content

[frontend] - disable fs instrumentation library#1473

Merged
puckpuck merged 3 commits intoopen-telemetry:mainfrom
puckpuck:frontend.disable-fs-instrumentation
Mar 21, 2024
Merged

[frontend] - disable fs instrumentation library#1473
puckpuck merged 3 commits intoopen-telemetry:mainfrom
puckpuck:frontend.disable-fs-instrumentation

Conversation

@puckpuck
Copy link
Copy Markdown
Contributor

@puckpuck puckpuck commented Mar 20, 2024

Changes

Fixes #1468

The instrumentaion-fs library was generating 2 spans for nearly every GET request into the frontend. Since we now use a playwright enabled loadgenerator, this was happening for every resource being loaded, leading to a much larger load and additional noise being generated. Disabling the library removes that noise.

This chart is a count of spans for the frontend service by name before and after the change in this PR was deployed.
Screenshot 2024-03-20 at 4 58 32 PM

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team March 20, 2024 21:14
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck merged commit 298c930 into open-telemetry:main Mar 21, 2024
@puckpuck puckpuck deleted the frontend.disable-fs-instrumentation branch March 21, 2024 19:29
neamulkabiremon pushed a commit to neamulkabiremon/ultimate-devops-project-demo that referenced this pull request Apr 16, 2025
* disable fs instrumentation library

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* disable fs instrumentation library

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
mohamed3637 added a commit to mohamed3637/opentelemetry-demo that referenced this pull request Oct 7, 2025
* disable fs instrumentation library

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* disable fs instrumentation library

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
cloud-hb pushed a commit to cloud-hb/opentelemetry-demo that referenced this pull request Nov 17, 2025
* disable fs instrumentation library

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* disable fs instrumentation library

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[frontend] - instrumentation-fs creates unecessary noise

3 participants