Skip to content

[checkout/product-catalog]: replace alpine base image with distroless image#2161

Merged
julianocosta89 merged 3 commits intoopen-telemetry:mainfrom
Red-GV:checkout-tool-pin
May 12, 2025
Merged

[checkout/product-catalog]: replace alpine base image with distroless image#2161
julianocosta89 merged 3 commits intoopen-telemetry:mainfrom
Red-GV:checkout-tool-pin

Conversation

@Red-GV
Copy link
Copy Markdown
Contributor

@Red-GV Red-GV commented Apr 29, 2025

Changes

This PR updates the checkout and product-catalog services to go1.24. In v1.24, there is tool version pinning within the go.mod itself.

This also updates the final image to a distroless image instead of the alpine one. The distroless one is smaller than alpine and won't carry anything more than the minimal environment needed to run.

I can undo the alpine -> distroless change moving to this image is not wanted.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@Red-GV Red-GV requested a review from a team as a code owner April 29, 2025 20:33
@Red-GV Red-GV force-pushed the checkout-tool-pin branch 2 times, most recently from f564569 to 273137d Compare April 29, 2025 21:35
Copy link
Copy Markdown
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, changes lgtm, but I think changing images would need a changelog entry. Would you mind adding it?

Don't have a strong opinion in using distroless in favor of alpine, but anything that reduces our images size is welcomed :)

@Red-GV Red-GV force-pushed the checkout-tool-pin branch from d4ef9e0 to 3b087fe Compare April 30, 2025 12:22
@Red-GV
Copy link
Copy Markdown
Contributor Author

Red-GV commented Apr 30, 2025

Changelog added. And here is the image sizes of the resulting image when I build them.

Screenshot 2025-04-30 at 8 16 55 AM

@Red-GV Red-GV force-pushed the checkout-tool-pin branch 3 times, most recently from 6fdf58d to 1b0c41f Compare April 30, 2025 15:36
@Red-GV Red-GV changed the title [checkout/product-catalog] update golang tool pinning process [checkout/product-catalog]: replace alpine base image with distroless image Apr 30, 2025
…ove to distroless images

Signed-off-by: Gerard Vanloo <gerard.vanloo@ibm.com>
@Red-GV Red-GV force-pushed the checkout-tool-pin branch from 1b0c41f to a3d8219 Compare May 5, 2025 02:30
Copy link
Copy Markdown
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just added a small Dockerfile nit

Co-authored-by: Roger Coll <roger.coll@elastic.co>
Copy link
Copy Markdown
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianocosta89 julianocosta89 merged commit 971d50d into open-telemetry:main May 12, 2025
31 checks passed
@Red-GV Red-GV deleted the checkout-tool-pin branch May 12, 2025 12:02
Hailong-am pushed a commit to Hailong-am/opentelemetry-demo that referenced this pull request Jun 9, 2025
… image (open-telemetry#2161)

* [checkout/product-catalog]: bump go to v1.24, pin tools via go.mod, move to distroless images

Signed-off-by: Gerard Vanloo <gerard.vanloo@ibm.com>

* Remove unneeded GO111MODULE

Co-authored-by: Roger Coll <roger.coll@elastic.co>

---------

Signed-off-by: Gerard Vanloo <gerard.vanloo@ibm.com>
Co-authored-by: Roger Coll <roger.coll@elastic.co>
cloud-hb pushed a commit to cloud-hb/opentelemetry-demo that referenced this pull request Nov 17, 2025
… image (open-telemetry#2161)

* [checkout/product-catalog]: bump go to v1.24, pin tools via go.mod, move to distroless images

Signed-off-by: Gerard Vanloo <gerard.vanloo@ibm.com>

* Remove unneeded GO111MODULE

Co-authored-by: Roger Coll <roger.coll@elastic.co>

---------

Signed-off-by: Gerard Vanloo <gerard.vanloo@ibm.com>
Co-authored-by: Roger Coll <roger.coll@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants