[shipping] Use cumulative metrics in shipping service to be consistent with the other services of the demo#2503
Conversation
|
@julianocosta89 I think that you are the author of the piece of code that specify to use Delta temporality in the Shipping service instead of the default cumulative temporality. Do you remember the rationale? See commit diff 00142af#diff-6e0dcf073aecdc8a72dcc3dc9264e65fe0b91c859b4017bde948bf48e90a72fdR45 |
|
hey @cyrille-leclerc thanks for that! The temporality should be configured via env var and not via code. Thanks for raising this |
|
Thanks @julianocosta89, |
|
@cyrille-leclerc the The whole demo should be able to be configured just with this env var to switch from cumulative to delta. |
Changes
Use cumulative metrics in shipping service to be consistent with the other services of the demo.
Note that Prometheus can't ingest delta metrics and we have an exception in the collector when using delta metrics.
I checked, metrics produced by the shipping metrics like
http.server.durationorapp.shipping.items_countwork well in PRometheus when produced as cumulative metrics.Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.