Skip to content

Add OTEL_RESOURCE_ATTRIBUTES to docker compose#664

Merged
julianocosta89 merged 8 commits intoopen-telemetry:mainfrom
svrnm:add_otel_resource_attributes_to_docker_compose
Jan 9, 2023
Merged

Add OTEL_RESOURCE_ATTRIBUTES to docker compose#664
julianocosta89 merged 8 commits intoopen-telemetry:mainfrom
svrnm:add_otel_resource_attributes_to_docker_compose

Conversation

@svrnm
Copy link
Copy Markdown
Member

@svrnm svrnm commented Dec 28, 2022

Changes

This adds OTEL_RESOURCE_ATTRIBUTES to the .env file and also makes use of it across all services. This allows to easily introduce service.namespace

Merge Requirements

Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm svrnm requested a review from a team December 28, 2022 13:17
svrnm and others added 2 commits January 9, 2023 09:16
@julianocosta89 julianocosta89 merged commit 5d330b6 into open-telemetry:main Jan 9, 2023
@puckpuck
Copy link
Copy Markdown
Contributor

Do we want to add this to the Helm chat as well? Is this different from what we call k8s.namespace.name we already export as a resource attribute when deployed with Helm?

@puckpuck puckpuck added the helm-update-required Requires an update to the Helm chart when released label Jan 17, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Add OTEL_RESOURCE_ATTRIBUTES to docker compose

Signed-off-by: svrnm <neumanns@cisco.com>

* Update CHANGELOG.md

Signed-off-by: svrnm <neumanns@cisco.com>

* Update CHANGELOG.md

* Update docker-compose.yml

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
mohamed3637 added a commit to mohamed3637/opentelemetry-demo that referenced this pull request Oct 7, 2025
* Add OTEL_RESOURCE_ATTRIBUTES to docker compose

Signed-off-by: svrnm <neumanns@cisco.com>

* Update CHANGELOG.md

Signed-off-by: svrnm <neumanns@cisco.com>

* Update CHANGELOG.md

* Update docker-compose.yml

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
cloud-hb pushed a commit to cloud-hb/opentelemetry-demo that referenced this pull request Nov 17, 2025
* Add OTEL_RESOURCE_ATTRIBUTES to docker compose

Signed-off-by: svrnm <neumanns@cisco.com>

* Update CHANGELOG.md

Signed-off-by: svrnm <neumanns@cisco.com>

* Update CHANGELOG.md

* Update docker-compose.yml

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm-update-required Requires an update to the Helm chart when released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants