[frontend] + [paymentservice] - update JS SDKs#853
Merged
puckpuck merged 4 commits intoopen-telemetry:mainfrom Apr 28, 2023
puckpuck:update_js_sdks
Merged
[frontend] + [paymentservice] - update JS SDKs#853puckpuck merged 4 commits intoopen-telemetry:mainfrom puckpuck:update_js_sdks
puckpuck merged 4 commits intoopen-telemetry:mainfrom
puckpuck:update_js_sdks
Conversation
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Contributor
Author
|
I need to update docs for this as well since the instrumentation code has changed for both services. I will get to that in the next day. |
julianocosta89
approved these changes
Apr 26, 2023
Member
julianocosta89
left a comment
There was a problem hiding this comment.
LGTM
Just a comment, but not a blocker
Member
@puckpuck, you mean transform processor? |
mviitane
approved these changes
Apr 27, 2023
Member
mviitane
left a comment
There was a problem hiding this comment.
Looks good. I got rid of these printouts when starting frontend in docker:
frontend | Accessing resource attributes before async attributes settled
frontend | Process is not running on K8S [Error: ENOENT: no such file or directory, access '/var/run/secrets/kubernetes.io/serviceaccount/token'] {
frontend | errno: -2,
frontend | code: 'ENOENT',
frontend | syscall: 'access',
frontend | path: '/var/run/secrets/kubernetes.io/serviceaccount/token'
frontend | }
frontend | Dropped 277266 spans because maxQueueSize reached
frontend | Dropped 38851 spans because maxQueueSize reached
frontend | npm notice
frontend | npm notice New minor version of npm available! 9.5.1 -> 9.6.5
frontend | npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
frontend | npm notice Run `npm install -g npm@9.6.5` to update!
frontend | npm notice
AlexanderWert
pushed a commit
to AlexanderWert/opentelemetry-demo
that referenced
this pull request
Jul 24, 2023
* update JS SDKs Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * only use instrumentation-fs when part of a trace Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update js SDKS Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* update JS SDKs Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * only use instrumentation-fs when part of a trace Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update js SDKS Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
mohamed3637
added a commit
to mohamed3637/opentelemetry-demo
that referenced
this pull request
Oct 7, 2025
* update JS SDKs Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * only use instrumentation-fs when part of a trace Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update js SDKS Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
cloud-hb
pushed a commit
to cloud-hb/opentelemetry-demo
that referenced
this pull request
Nov 17, 2025
* update JS SDKs Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * only use instrumentation-fs when part of a trace Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update js SDKS Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes: #826
Updates the JS SDKs to the latest. Allows us to remove the filter processor in the collector. This change also configures the
instrumentation-fslibrary to only instrument calls when part of another trace. This was required because that library would generate hundreds/thousands of single-span traces on startup.Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.