Add WCF support for IRequestSessionChannel and IDuplexChannel#1374
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1374 +/- ##
==========================================
+ Coverage 73.91% 74.07% +0.16%
==========================================
Files 267 258 -9
Lines 9615 9551 -64
==========================================
- Hits 7107 7075 -32
+ Misses 2508 2476 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| } | ||
|
|
||
| protected ICommunicationObject Inner { get; } | ||
| protected T Inner { get; } |
There was a problem hiding this comment.
@repl-chris I just pushed a little bit of refactoring so that we can expose a strongly-typed "Inner" on the base class. That gets rid of the need for [private|protected] new [ChannelType] Inner { get => ([ChannelType])base.Inner; } we had been using in all the derived classes.
There was a problem hiding this comment.
Nice....looks good 👍
|
@repl-chris This looks good to me but before we can merge we need to update the CHANGELOG and perhaps the README with the new supported matrix? |
@CodeBlanch done 👍 |
Kielek
left a comment
There was a problem hiding this comment.
Chnagelog and README LGTM. Approving and merging based on previous @CodeBlanch comment
Fixes #1369
Changes
The provided configuration from the issue uses an
IRequestSessionChannelshape, which the instrumentation did not yet support. This PR adds support forIRequestSessionChannel. I've also enabled support forIDuplexChannelshaped channels, since the implementation actually already supported it as part of theIDuplexSessionChannelimplementation.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes