[Instrumentation.Process] Adjust metrics and attributes to Sem. Conv. 1.25.0#1643
Merged
Kielek merged 8 commits intoApr 12, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1643 +/- ##
============================================
+ Coverage 73.91% 100.00% +26.08%
============================================
Files 267 2 -265
Lines 9615 55 -9560
============================================
- Hits 7107 55 -7052
+ Misses 2508 0 -2508
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
changed the title
Kielek
added
the
comp:instrumentation.process
Member
Author
|
@kmcclellan, FYI |
Kielek
marked this pull request as ready for review
April 9, 2024 12:06
lachmatt
reviewed
Apr 10, 2024
lachmatt
approved these changes
Apr 10, 2024
Member
Author
|
@Yun-Ting, @vishweshbankwar, could you please check? |
| | `s` | ObservableCounter | `Double` | state | user, system | | ||
| | Units | Instrument Type | Value Type | Attribute Key(s) | Attribute Values | | ||
| |-------|-------------------|------------|-------------------|------------------| | ||
| | `s` | ObservableCounter | `Double` | process.cpu.state | user, system | |
Member
There was a problem hiding this comment.
Not a blocking comment but spec defines this as Counter and we have it as ObservableCounter. I do not know the history of this, @Yun-Ting any idea?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1638.
Changes
process.cpu.timemetric attribute renamed fromstatetoprocess.cpu.state,process.memory.usageandprocess.memory.virtual,process.threadsrenamed toprocess.thread.count(its unit changed from
{threads}to{thread}.process.cpu.countis not part of the semantic convention (and it never was). It is still produced.Also not all metrics defined by sem.conv. are covered.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed