[Resources.Process] Rename process detector namespace#1717
Merged
Kielek merged 11 commits intoMay 15, 2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
+ Coverage 73.91% 76.26% +2.34%
==========================================
Files 267 298 +31
Lines 9615 11622 +2007
==========================================
+ Hits 7107 8863 +1756
- Misses 2508 2759 +251 Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
reviewed
May 13, 2024
Kielek
left a comment
Member
There was a problem hiding this comment.
Hi @matt-hensley, I have merged changes related to creating bugfixes/features to this branch.
Couple of comments added to specific files.
What is more important we need changelog entry containing two thiings.
- Package rename
- How to migrate from old construction to the new one.
# Conflicts: # .github/ISSUE_TEMPLATE/bug_report.yml # .github/ISSUE_TEMPLATE/feature_request.yml # .github/workflows/ci.yml # opentelemetry-dotnet-contrib.sln
Kielek
approved these changes
May 15, 2024
lachmatt
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Changes are following guidelines in #1610.
AddProcessDetectorextension method forResourceBuilderFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes