Rework internal logic for determining the trace id created by AWS Lambda#3410
Conversation
github-actions
bot
added
infra
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3410 +/- ##
==========================================
+ Coverage 70.79% 70.87% +0.08%
==========================================
Files 440 440
Lines 17265 17265
==========================================
+ Hits 12222 12236 +14
+ Misses 5043 5029 -14 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The GitHub check looks like an unrelated possibly transient error since the failure is in |
| <PackageVersion Include="Amazon.Lambda.APIGatewayEvents" Version="[2.7.0,)" /> | ||
| <PackageVersion Include="Amazon.Lambda.ApplicationLoadBalancerEvents" Version="[2.2.0,)" /> | ||
| <PackageVersion Include="Amazon.Lambda.Core" Version="[2.2.0,)" /> | ||
| <PackageVersion Include="Amazon.Lambda.Core" Version="[2.8.0,)" /> |
There was a problem hiding this comment.
This is quite a large step forward in terms of the minimum version (~2 years of changes).
There was a problem hiding this comment.
Changes made to Amazon.Lambda.Core are done very conservatively due to the nature of being being deployed to the Lambda managed runtime so changes are often picked up in a not opt-in way. The changes from 2.2.0 to 2.8.0 are all backwards compatible and we need this change for the correct evaluation of trace id.
There was a problem hiding this comment.
IMO it is still worth to add this information to the CHANGELOG. It is a practice to reflect such changes in this repo.
There was a problem hiding this comment.
That makes sense, I pushed up another commit updating the change log message to include the version bump.
src/OpenTelemetry.Instrumentation.AWSLambda/Implementation/AWSLambdaUtils.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
37859b1
7 participants
Changes
In
Amazon.Lambda.Corewe have reworked the logic that for determining the trace id. TheOpenTelemetry.Instrumentation.AWSLambdapackage has been updated to take advantage of the new API added inAmazon.Lambda.Corefor getting the current trace id.I didn't add any new tests as the existing tests covered the the internal change and users will not see any difference.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes