[Infra] Digitally sign DLLs with cosign#4637
Merged
Merged
Conversation
Copy the approach for the .NET SDK and sign the assemblies in the NuGet packages with a cosign keyless blob. Resolves open-telemetry#4603.
github-actions
Bot
added
infra
martincostello
commented
Jul 2, 2026
Run on Windows to fix the signature verification.
Handle finding the TFM to use for cosign when the package only has one TFM.
Fix-up target for handling multi and single TFM packages correctly.
Update patterns to handle DLLs for projects that only produce one TFM.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Sigstore/cosign-based digital signing for the DLLs shipped inside NuGet packages produced by this repo, aligning the release artifact security posture with the main OpenTelemetry .NET SDK repo.
Changes:
- Document DLL signing and verification steps (cosign
verify-blob) in the repository README. - Add an MSBuild packing target to include generated
.dll.sigstore.jsonbundles alongside packaged DLLs underlib/<tfm>/. - Update the publish workflow to (a) sign built DLLs keylessly with cosign and (b) verify signatures during package validation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Adds end-user documentation for verifying cosign signatures embedded in NuGet packages. |
| build/Common.prod.props | Packs Sigstore bundle files (*.dll.sigstore.json) into NuGet packages next to the corresponding DLLs. |
| .github/workflows/publish-packages.yml | Signs build outputs with cosign and verifies signatures as part of package validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Skip directories that were not built.
Change version to date.
Make markdownlint happy with line lengths.
martincostello
enabled auto-merge
July 2, 2026 20:48
Kielek
disabled auto-merge
July 3, 2026 10:20
Member
I think it is worth to do this. |
Add an entry for this PR to every CHANGELOG.
github-actions
Bot
assigned
ejsmith,
evgenyfedorov2,
fred2u,
g7ed6e,
hananiel,
Havret,
IliaBrahinets,
iskiselev and
Kielek
This was referenced Jul 16, 2026
Closed
Open
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4603
Changes
Copy the approach for the .NET SDK and sign the assemblies in the NuGet packages with a cosign keyless blob.
Tested here.
I haven't added this to the CHANGELOGs, but I can if wanted.
Merge requirement checklist
Unit tests added/updatedCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)