Skip to content

[Instrumenation.WCF] Adjust activity source name #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utpilla merged 2 commits into from
Aug 9, 2022
Merged

[Instrumenation.WCF] Adjust activity source name #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81ff7e8
[Instrumenation.WCF] Adjust activity source name
Kielek Aug 9, 2022
4bed9bf
Merge branch 'main' into wcf-activity-source-name
Kielek Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

* Updated OTel SDK package version to 1.3.0
([#569](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/569))
* Changed activity source name from `OpenTelemetry.WCF`
to `OpenTelemetry.Instrumentation.Wcf`
([#570](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/570))

## 1.0.0-rc.6

Expand Down
10 changes: 6 additions & 4 deletions src/OpenTelemetry.Instrumentation.Wcf/Implementation/WcfInstrumentationActivitySource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Reflection;
using System.ServiceModel.Channels;

namespace OpenTelemetry.Instrumentation.Wcf;
Expand All @@ -26,11 +27,12 @@ namespace OpenTelemetry.Instrumentation.Wcf;
/// </summary>
internal static class WcfInstrumentationActivitySource
{
public const string ActivitySourceName = "OpenTelemetry.WCF";
public const string IncomingRequestActivityName = ActivitySourceName + ".IncomingRequest";
public const string OutgoingRequestActivityName = ActivitySourceName + ".OutgoingRequest";
internal static readonly AssemblyName AssemblyName = typeof(WcfInstrumentationActivitySource).Assembly.GetName();
internal static readonly string ActivitySourceName = AssemblyName.Name;
internal static readonly string IncomingRequestActivityName = ActivitySourceName + ".IncomingRequest";
internal static readonly string OutgoingRequestActivityName = ActivitySourceName + ".OutgoingRequest";

private static readonly Version Version = typeof(WcfInstrumentationActivitySource).Assembly.GetName().Version;
private static readonly Version Version = AssemblyName.Version;

public static ActivitySource ActivitySource { get; } = new ActivitySource(ActivitySourceName, Version.ToString());

Expand Down