[Instrumentation.Process] Update OTel API version to 1.4.0-beta.2 and change Prcoess metrics type to ObservableUpDownCounter#751
Merged
Conversation
Yun-Ting
marked this pull request as ready for review
November 2, 2022 19:23
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
=======================================
Coverage 77.38% 77.38%
=======================================
Files 176 176
Lines 5294 5294
=======================================
Hits 4097 4097
Misses 1197 1197
|
utpilla
approved these changes
Nov 2, 2022
cijothomas
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Addressed TODO.
Update OTel API version to be
1.4.0-beta.2and change process metrics type from ObservableGauge toObservableUpDownCounter. Updated instruments are: "process.memory.usage", "process.memory.virtual" and "process.threads".CHANGELOG.mdupdated for non-trivial changes