Skip to content

[Instrumentation.Process] Update OTel API version to 1.4.0-beta.2 and change Prcoess metrics type to ObservableUpDownCounter#751

Merged
cijothomas merged 5 commits into
open-telemetry:mainfrom
Yun-Ting:yunl/piApi
Nov 2, 2022
Merged

[Instrumentation.Process] Update OTel API version to 1.4.0-beta.2 and change Prcoess metrics type to ObservableUpDownCounter#751
cijothomas merged 5 commits into
open-telemetry:mainfrom
Yun-Ting:yunl/piApi

Conversation

@Yun-Ting

@Yun-Ting Yun-Ting commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Changes

Addressed TODO.
Update OTel API version to be 1.4.0-beta.2 and change process metrics type from ObservableGauge to ObservableUpDownCounter. Updated instruments are: "process.memory.usage", "process.memory.virtual" and "process.threads".

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@Yun-Ting
Yun-Ting marked this pull request as ready for review November 2, 2022 19:23
@Yun-Ting
Yun-Ting requested a review from a team November 2, 2022 19:23
@utpilla utpilla added the comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process label Nov 2, 2022
@codecov

codecov Bot commented Nov 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #751 (18224dd) into main (30eddfa) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage   77.38%   77.38%           
=======================================
  Files         176      176           
  Lines        5294     5294           
=======================================
  Hits         4097     4097           
  Misses       1197     1197           
Impacted Files Coverage Δ
...elemetry.Instrumentation.Process/ProcessMetrics.cs 100.00% <100.00%> (ø)

@cijothomas
cijothomas merged commit 39e2c91 into open-telemetry:main Nov 2, 2022
@Yun-Ting Yun-Ting changed the title [Instrumentation.Process] Update OTel API version to 1.4.0-beta.2 and change runtime metrics type to ObservableUpDownCounter [Instrumentation.Process] Update OTel API version to 1.4.0-beta.2 and change Prcoess metrics type to ObservableUpDownCounter Nov 2, 2022
@Yun-Ting
Yun-Ting deleted the yunl/piApi branch November 2, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants