[Instrumentation.Process] Exposed required metric process.cpu.count for computing CPU utilization in the backend.#981
Conversation
|
Can we open discussion on spec side once more time? The minimal effort - decide the name in the spec side. |
CodeBlanch
left a comment
There was a problem hiding this comment.
process.processors is kind of tongue twister 🤣 process.cpu.count is much nicer IMO. Probably process.threads -> process.thread.count would also be good.
I've created an issue in the spec side! |
process.processors for computing CPU utilization in the backend.process.processors for computing CPU utilization in the backend. (pending spec discussion)
reyang
left a comment
There was a problem hiding this comment.
LGTM, the spec dependency is not a blocker IMHO given the component and the spec are both preview/experimental.
process.processors for computing CPU utilization in the backend. (pending spec discussion)process.processors for computing CPU utilization in the backend.
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
process.processors for computing CPU utilization in the backend.process.cpu.count for computing CPU utilization in the backend.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main open-telemetry/opentelemetry-specification#981 +/- ##
==========================================
+ Coverage 68.11% 68.13% +0.02%
==========================================
Files 184 184
Lines 7013 7021 +8
==========================================
+ Hits 4777 4784 +7
- Misses 2236 2237 +1
|
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Based on spec discussion: open-telemetry/opentelemetry-specification#2392 (comment)
Related to: #972.
Changes
Exposed required metric
process.processorsfor computing CPU utilization in the backend.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes