Versioning based on release tag#2772
Merged
Merged
Conversation
to correctly calculate version
nrcventura
reviewed
Jul 25, 2023
lachmatt
approved these changes
Jul 26, 2023
nrcventura
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #2601
What
MinVer - natively for C# code
Native code versioned by Nuke tasks (version taken from MinVer).
No need to modify code, except installation script, before release.
Tests
CI.
Tested with tag
v5.2.6on my fork: https://github.com/Kielek/opentelemetry-dotnet-instrumentation/actions/runs/5656282012Checklist
CHANGELOG.mdis updated.Newfeatures are covered by tests.Notes
Possible follow up - find a way to avoid manual changes in installation scripts. Possibly we could do it by nuke and then copy it to artifacts.
Related issues: