Update OpAMP port to 4320#5057
Conversation
|
A few locations should be fixed in proto as well > |
Updated opamp proto to v0.17.0 |
|
Should include a new opamp client version also here, so ports align with versions. Converting to draft. |
OpAmp version bumped here: #5093 |
There was a problem hiding this comment.
Pull request overview
Updates OpAMP configuration defaults and related test/spec artifacts to reflect the OpAMP default port change from 4318 to 4320, aligning this repo’s docs/tests (and embedded OpAMP proto used by integration tests) with upstream spec changes.
Changes:
- Updated OpAMP server URL examples/expectations in unit tests and file-based configuration test YAML to use port 4320.
- Updated documentation and changelog to reflect the new default OpAMP port (4320).
- Updated the embedded
opamp.protoused by IntegrationTests (including the URL example and additional upstream schema changes).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/OpenTelemetry.AutoInstrumentation.Tests/Configurations/FileBased/Parser/ParserOpAmpTests.cs | Updates expected OpAMP server URL port in parser tests. |
| test/OpenTelemetry.AutoInstrumentation.Tests/Configurations/FileBased/Files/TestOpAmpFile.yaml | Updates test YAML OpAMP server URL to port 4320. |
| test/OpenTelemetry.AutoInstrumentation.Tests/Configurations/FileBased/FileBasedOpAmpSettingsTests.cs | Updates OpAMP settings test URL to port 4320. |
| test/IntegrationTests/opentelemetry/proto/opamp/opamp.proto | Updates embedded OpAMP proto (including example URL port) and syncs additional spec changes. |
| src/OpenTelemetry.AutoInstrumentation/Configurations/FileBasedConfiguration/OtlpHttpExporterConfig.cs | Updates an OTLP HTTP exporter doc comment (currently to 4320). |
| docs/file-based-configuration.md | Updates OpAMP configuration example to port 4320. |
| docs/config.md | Updates default value shown for OTEL_DOTNET_AUTO_OPAMP_SERVER_URL to port 4320. |
| CHANGELOG.md | Records OpAMP default port change from 4318 to 4320. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Why
open-telemetry/opentelemetry-dotnet-contrib#4374
open-telemetry/opamp-spec#323
What
OpAMP port was changed from 4318 to 4320
Tests
Updated.
Checklist
CHANGELOG.mdis updated.