Http/ASP.NET/Core instrumentation now populates the raw objects into activity's custom property.
Proposals:
-
Instead of doing this always, conditionally do it if explicitly enabled to avoid any unwanted perf hit for users who don't plan to leverage this.
-
Should we somehow clear the customproperty after all the request is finished? Storing the raw httprequest/response etc to the activity, could delay them from being GC eligible? (The activity could be held in the Exporter for a long time..)
-
Make the key names as public property on the corresponding options class.
Http/ASP.NET/Core instrumentation now populates the raw objects into activity's custom property.
Proposals:
Instead of doing this always, conditionally do it if explicitly enabled to avoid any unwanted perf hit for users who don't plan to leverage this.
Should we somehow clear the customproperty after all the request is finished? Storing the raw httprequest/response etc to the activity, could delay them from being GC eligible? (The activity could be held in the Exporter for a long time..)
Make the key names as public property on the corresponding options class.