Sql for .net framework never calls Enrich

[davhdavh]

Bug Report

https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlEventSourceListener.netfx.cs

It never calls Enrich anywhere.

net462 build.

Symptom

This is valid code in .net framework lib, but it never calls the Enrich method.

                      .AddSqlClientInstrumentation(o => {
                          o.Enrich         = (activity, _, _) => activity.DisplayName = "Sql";
                       })

What is the expected behavior?

Enrich called

What is the actual behavior?

Enrich never called

Reproduce

                      .AddSqlClientInstrumentation(o => {
                          o.Enrich         = (activity, _, _) => activity.DisplayName = "Sql";
                       })

[cijothomas]

https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Instrumentation.SqlClient#enrich Enrich is not supported in .NET FW.

[davhdavh]

It specifically says Note: Enrich is supported on .NET and .NET Core runtimes only. Also if it wasn't supposed to be supported why isn't it removed with an #if like many of the other things?

…

On Tue, Jan 17, 2023, 22:45 Cijo Thomas ***@***.***> wrote: Closed #4080 <#4080> as completed. — Reply to this email directly, view it on GitHub <#4080 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJFIDNZZAQ6WK2RZZIPMJ3WS247ZANCNFSM6AAAAAAT4SV7AE> . You are receiving this because you authored the thread.Message ID: <open-telemetry/opentelemetry-dotnet/issue/4080/issue_event/8247057650@ github.com>

[cijothomas]

It specifically says Note: Enrich is supported on .NET and .NET Core runtimes only. Also if it wasn't supposed to be supported why isn't it removed with an #if like many of the other things?
…
On Tue, Jan 17, 2023, 22:45 Cijo Thomas @.***> wrote: Closed #4080 <#4080> as completed. — Reply to this email directly, view it on GitHub <#4080 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJFIDNZZAQ6WK2RZZIPMJ3WS247ZANCNFSM6AAAAAAT4SV7AE . You are receiving this because you authored the thread.Message ID: <open-telemetry/opentelemetry-dotnet/issue/4080/issue_event/8247057650@ github.com>

It was intentionally done to have same public API in all targets. #3900