Rename AddActivitySource to AddSource, use params#1036
Merged
cijothomas merged 1 commit intomasterfrom Aug 11, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
==========================================
- Coverage 77.17% 77.11% -0.06%
==========================================
Files 221 221
Lines 6164 6162 -2
==========================================
- Hits 4757 4752 -5
- Misses 1407 1410 +3
|
cijothomas
approved these changes
Aug 10, 2020
rajkumar-rangaraj
approved these changes
Aug 10, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on:
Changes
AddActivitySourcetoAddSourceparamsapproach.I will send a separate PR to clean up the
CHANGELOG.mdas it is becoming messy now.Please provide a brief description of the changes here. Update the
CHANGELOG.mdfor non-trivial changes.For significant contributions please make sure you have completed the following items: