Update Exporter.Shutdown to meet with the latest spec#1285
Merged
CodeBlanch merged 5 commits intomasterfrom Sep 19, 2020
Merged
Update Exporter.Shutdown to meet with the latest spec#1285CodeBlanch merged 5 commits intomasterfrom
CodeBlanch merged 5 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
- Coverage 79.16% 79.15% -0.01%
==========================================
Files 215 215
Lines 6176 6175 -1
==========================================
- Hits 4889 4888 -1
Misses 1287 1287
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1282.
Changes
Changed ActivityExporter.OnShutdown to return bool.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes